Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose correct protocol when using proxy #230

Closed
mattfysh opened this issue Feb 1, 2013 · 0 comments
Closed

Choose correct protocol when using proxy #230

mattfysh opened this issue Feb 1, 2013 · 0 comments

Comments

@mattfysh
Copy link

mattfysh commented Feb 1, 2013

The req object is not replaced with the correct module (http/https) when a proxy is used. If the src.protocol changes when the following code is run, then the req object may not match what the original src.protocol was:

  if (process.env.HTTP_PROXY) {
    src = url.parse(process.env.HTTP_PROXY);
    src.path = this.assetUrl;
  }

This is in package.js.

@satazor satazor closed this as completed in 36e790d Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants