Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitUtils consistently misnames min as maxCombinedSplitSize #453

Open
gerashegalov opened this issue Oct 22, 2015 · 4 comments
Open

SplitUtils consistently misnames min as maxCombinedSplitSize #453

gerashegalov opened this issue Oct 22, 2015 · 4 comments

Comments

@gerashegalov
Copy link
Contributor

the logic in SplitUtils#getCombinedSplits clearly treats maxCombinedSplitSize as the min, and the actual split size may well exceed it.

@gerashegalov gerashegalov changed the title SplitUtils consistently misnames max for min split size SplitUtils consistently misnames min as maxCombinedSplitSize Oct 22, 2015
@isnotinvain
Copy link
Contributor

I guess it's poorly named, I think it's more like "target split size, but you may go over it if the last split to be combined is bigger" or something like that, right?

@dvryaboy
Copy link
Contributor

Last split might be smaller, too.

@gerashegalov
Copy link
Contributor Author

@dvryaboy correct, the last split can be smaller.

@gerashegalov
Copy link
Contributor Author

@dvryaboy @isnotinvain max and min can in theory be both targets. In most situations but a small single split, we keep piling up on a single split as long as we have not reached the min target. Would minTargetSize work to clarify that normally it's a lower bound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants