Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COCOAPODS.md with installation instructions #58

Merged
merged 1 commit into from Oct 19, 2020

Conversation

liamnichols
Copy link
Contributor

Following #56, this change adds a COCOAPODS.md document describing ways to configure the TwitterImagePipeline pod for use with the extended subspecs.

I was thinking about adding a section to the bottom of README.md but wasn't sure if it was best to do that since there are no manual usage instructions to go with it.. Let me know if you want me to add something though.

Once merged, will it be possible to get a 2.24.1 release to push up the new Podspec? I can bump versions or update CHANGELOG.md here if it would help?

Thanks!

@liamnichols
Copy link
Contributor Author

@NSProgrammer: Hope all is well.. I don't suppose you would get a chance anytime soon to check out this PR and bump the CocoaPods release? 🙏

@NSProgrammer NSProgrammer merged commit aa0b3bc into twitter:master Oct 19, 2020
@NSProgrammer
Copy link
Collaborator

I don't think we need to bump the version, this is just documentation updating. We can rev COCOAPODS.md example version numbers in future revisions or not -- it is implied to figure out the version when adding that to the spec.

@liamnichols
Copy link
Contributor Author

I don't think we need to bump the version, this is just documentation updating. We can rev COCOAPODS.md example version numbers in future revisions or not -- it is implied to figure out the version when adding that to the spec.

@NSProgrammer: the request to bump the version and do a new release was so that we can actually start using the new subspecs 🙂

@NSProgrammer
Copy link
Collaborator

OK, done

@liamnichols liamnichols deleted the ln/cocoapods-docs branch October 21, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants