Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cascading Tuple & TupleEntry copies #1504

Open
johnynek opened this issue Feb 5, 2016 · 0 comments
Open

reduce cascading Tuple & TupleEntry copies #1504

johnynek opened this issue Feb 5, 2016 · 0 comments

Comments

@johnynek
Copy link
Collaborator

johnynek commented Feb 5, 2016

According to @ianoc 's benchmarks it can be 5-8%.

See:

https://gitter.im/twitter/scalding?at=56b4eda42079fb5f156f1697

there are APIs that should allow the code in Operations to keep one private instance and reuse. In the case of hash keys, they are almost certainly single items. In that case, just pull them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant