Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently call validateTap in all src.toIterator implement #1637

Open
gerashegalov opened this issue Feb 7, 2017 · 1 comment
Open

Consistently call validateTap in all src.toIterator implement #1637

gerashegalov opened this issue Feb 7, 2017 · 1 comment

Comments

@gerashegalov
Copy link
Contributor

All toIterator impls should consistently validate taps in order to be able to rely on the iterator completeness.
Compare com.twitter.scalding.Mappable#toIterator and com.twitter.scalding.commons.source.LzoCodec#toIterator, etc.
@johnynek
Copy link
Collaborator

johnynek commented Feb 7, 2017

cc @isnotinvain the whole validation thing is racy also. I'm not sure validateTap is the full solution.

It may be that we want make it easier for the the taps to validate as they read so they don't return partial results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnynek @gerashegalov