Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up warnings related to transient #1722

Open
johnynek opened this issue Sep 23, 2017 · 0 comments
Open

clean up warnings related to transient #1722

johnynek opened this issue Sep 23, 2017 · 0 comments

Comments

@johnynek
Copy link
Collaborator

We use transient in many classes to deal with cascading related serialization issues.

We are using it on a number of parameters, which in 2.11 are now warning that is a no-op.

We should verify it is a no-op (make non-serializable args, and see that they still serialize), and remove the transient annotations that are warning.

Example:

[warn] /Users/oscar/oss/scalding/scalding-commons/src/main/scala/com/twitter/scalding/commons/source/VersionedKeyValSource.scala:57: no valid targets for annotation on value codec - it is discarded unused. You may specify targets with meta-annotations, e.g. @(transient @param)
[warn]     implicit @transient codec: Injection[(K, V), (Array[Byte], Array[Byte])]) extends Source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant