-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URGENT: MatrixProduct.scala is missing Matrix * col and row * Matrix #248
Comments
I started on this earlier today, should have something once I get out of meetings. |
Glad I mentioned something on the mailing list ;) @ccsevers do you have a repo/branch I can clone? |
I put up a new branch in my fork called vector_implicits. Let me write a couple tests and I'll open a pull request. I added row_Mat, Mat_col, vec+vec, vec-vec, vec hProd vec and col * row (outer product, dangerous). |
Sweet, Chris. Outer-product is interesting. One idea I had for outer-product was to make a separate class for it, and not actually materialize the result. Since: We can add outer-product now (people should just be careful), but it might be interesting to think of these algebraic optimizations that a Matrix aware scheduler can do. |
WTF?
Someone should quickly add something like:
mat * (col.toMatrix(true)).getCol(true)
((row.toMatrix(true)) * mat).getRow(true)
That should be in before the next release. A fancier algorithm could possibly improve this when the vectors are really small.
The text was updated successfully, but these errors were encountered: