Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config keys are always merged, even if we want to overwrite #56

Closed
johnynek opened this issue Apr 12, 2012 · 2 comments
Closed

config keys are always merged, even if we want to overwrite #56

johnynek opened this issue Apr 12, 2012 · 2 comments

Comments

@johnynek
Copy link
Collaborator

https://groups.google.com/forum/?fromgroups#!topic/cascading-user/Bvev1F8ZVOM

If a key is already set by an incoming Config, it looks like there is no way to overwrite it. The API should allow this.

@johnynek
Copy link
Collaborator Author

https://github.com/twitter/scalding/blob/master/src/main/scala/com/twitter/scalding/Mode.scala#L102

That's the problem: we are always calling unionValues.

@johnynek
Copy link
Collaborator Author

This was fixed. Now you override the config method in your job:

https://github.com/twitter/scalding/blob/develop/src/main/scala/com/twitter/scalding/Job.scala#L100

Look at the incoming mode.config, and choose how to update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant