Skip to content

Commit

Permalink
Polish based on feedback from @oreoshake.
Browse files Browse the repository at this point in the history
  • Loading branch information
ptoomey3 authored and oreoshake committed Jun 21, 2017
1 parent e5fd743 commit 48c69ab
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/secure_headers/headers/clear_site_data.rb
Expand Up @@ -41,7 +41,7 @@ def validate_config!(config)
end
end

# Public: Transform a Clear-Site-Data config (an Array of String) into a
# Public: Transform a Clear-Site-Data config (an Array of Strings) into a
# String that can be used as the value for the Clear-Site-Data header.
#
# types - An Array of String of types of data to clear.
Expand Down
12 changes: 6 additions & 6 deletions spec/lib/secure_headers/headers/clear_site_data_spec.rb
Expand Up @@ -21,15 +21,15 @@ module SecureHeaders

expect(name).to eq(ClearSiteData::HEADER_NAME)
expect(value).to eq(
ClearSiteData.make_header_value(ClearSiteData::ALL_TYPES)
%("cache", "cookies", "storage", "executionContexts")
)
end

it "returns specified types" do
name, value = described_class.make_header(["foo", "bar"])

expect(name).to eq(ClearSiteData::HEADER_NAME)
expect(value).to eq(ClearSiteData.make_header_value(["foo", "bar"]))
expect(value).to eq(%("foo", "bar"))
end
end

Expand Down Expand Up @@ -78,10 +78,10 @@ module SecureHeaders
end

describe "make_header_value" do
it "returns a string of quoted values that are comma separated" do
value = described_class.make_header_value(["foo", "bar"])
expect(value).to eq(%("foo", "bar"))
end
it "returns a string of quoted values that are comma separated" do
value = described_class.make_header_value(["foo", "bar"])
expect(value).to eq(%("foo", "bar"))
end
end
end
end

0 comments on commit 48c69ab

Please sign in to comment.