Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false booleans being included in the CSP directive #253

Merged
merged 2 commits into from
May 9, 2016
Merged

Fix false booleans being included in the CSP directive #253

merged 2 commits into from
May 9, 2016

Conversation

stefansundin
Copy link
Contributor

I was using upgrade_insecure_requests: false but I still got upgrade-insecure-requests in my header. It would appear this is a bug?

@oreoshake
Copy link
Contributor

Ha! What a simple mistake 😄. The fix is great, but would you mind adding a test?

@stefansundin
Copy link
Contributor Author

Test added. Does it cover what you were looking for?

@oreoshake oreoshake merged commit 0d054b7 into github:master May 9, 2016
@oreoshake
Copy link
Contributor

Thanks! I'll cut a new gem shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefansundin @oreoshake