Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie config needs a default #366

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Cookie config needs a default #366

merged 4 commits into from
Oct 4, 2017

Conversation

apanzerj
Copy link

@apanzerj apanzerj commented Oct 4, 2017 •
edited

All PRs:

  • Has tests -> not yet
  • Documentation updated -> not needed

@apanzerj apanzerj force-pushed the apanzerj/nil_config_cookies branch 2 times, most recently from 40f3556 to a3d2208 Compare October 4, 2017 00:15
@oreoshake
Copy link
Contributor

Looks good, I'll give it a try tomorrow.

@oreoshake
Copy link
Contributor

Heh, it looks like setting cookies = {} sets the secure defaults in the current release.

Given that this was supposed to be the biggest breaking change of 4.x, I think we have to release a 5.x since this will actually break things.

@oreoshake oreoshake merged commit 4e1b8c2 into github:master Oct 4, 2017
@apanzerj
Copy link
Author

apanzerj commented Oct 4, 2017

On the plus side: I helped :-D

@oreoshake
Copy link
Contributor

I've released 5.0.0.alpha01 with this change. It will be some time before I can dogfood it.

@apanzerj
Copy link
Author

apanzerj commented Oct 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apanzerj @oreoshake