Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small typo fix: a minimum … IS required #370

Closed
wants to merge 1 commit into from
Closed

small typo fix: a minimum … IS required #370

wants to merge 1 commit into from

Conversation

s-gerber
Copy link

This PR fixes just a small typo.

Thank you for your work

@jacobbednarz
Copy link
Contributor

Howdy @s-gerber!

Thanks for the contribution! 🎈 I'm pretty average with the English language however it looks like "are" is the correct usage in this case - see grammarly on is vs are usage. Here we are talking about multiple pins so the noun (pins) is plural.

@oreoshake
Copy link
Contributor

I abstain. Tie vote goes to @gregose.

@gregose
Copy link
Member

gregose commented Oct 31, 2017

Oh no... grammar sniped. I did a couple minutes of intense internet grammar research and while it seems like it could go either way, I like the rule of thumb proposed at http://grammar.ccc.commnet.edu/grammar/grammarlogs3/grammarlogs488.htm.

You'd say "A variety of cigars is a good thing" because it's the variety, a singular notion, that you're emphasizing. On the other hand, you might say "A variety of good cigars are available" when you want to emphasize a number of cigars in their marvelous plurality.

In this case, it feels like here we are emphasizing that there are multiple pins required, not the singular minimum of them. My vote goes to keeping it “are.”

@oreoshake
Copy link
Contributor

@s-gerber it sounds like there's disagreement here. I'm going to let this sit open for a few more days then close it out. Either way, thanks again for the contribution!

I LOVE DOCS PRs ❤️

@s-gerber
Copy link
Author

s-gerber commented Oct 31, 2017

Oh I (obviously) didn't know that is could be right here as well. I was just thinking that to be is referencing the (required) minimum here.

So absolutely no problem for me if it won't be merged. 😉

PS: travis is having a capaticity issue

@oreoshake
Copy link
Contributor

Closing this one out. It has been nearly 90 days and the public request for comments has been closed. I appreciate the discussion!

@oreoshake oreoshake closed this Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants