Commit
… user groups are served
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -220,30 +220,7 @@ object HomeTweetTypePredicates { | |
_.getOrElse(ConversationModule2DisplayedTweetsFeature, false)), | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
SeanFree
|
||
("conversation_module_has_gap", _.getOrElse(ConversationModuleHasGapFeature, false)), | ||
("served_in_recap_tweet_candidate_module_injection", _ => false), | ||
("served_in_threaded_conversation_module", _ => false), | ||
( | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
rafaelbeckel
|
||
"author_is_elon", | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
edmundpf
|
||
candidate => | ||
candidate | ||
.getOrElse(AuthorIdFeature, None).contains(candidate.getOrElse(DDGStatsElonFeature, 0L))), | ||
( | ||
"author_is_power_user", | ||
candidate => | ||
candidate | ||
.getOrElse(AuthorIdFeature, None) | ||
.exists(candidate.getOrElse(DDGStatsVitsFeature, Set.empty[Long]).contains)), | ||
( | ||
"author_is_democrat", | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
GeorgeShao
|
||
candidate => | ||
candidate | ||
.getOrElse(AuthorIdFeature, None) | ||
.exists(candidate.getOrElse(DDGStatsDemocratsFeature, Set.empty[Long]).contains)), | ||
( | ||
"author_is_republican", | ||
candidate => | ||
candidate | ||
.getOrElse(AuthorIdFeature, None) | ||
.exists(candidate.getOrElse(DDGStatsRepublicansFeature, Set.empty[Long]).contains)), | ||
("served_in_threaded_conversation_module", _ => false) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
BankkRoll
|
||
) | ||
|
||
val PredicateMap = CandidatePredicates.toMap | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,10 @@ | ||
package com.twitter.home_mixer.functional_component.feature_hydrator | ||
|
||
import com.twitter.config.yaml.YamlMap | ||
import com.twitter.finagle.tracing.Annotation.BinaryAnnotation | ||
import com.twitter.finagle.tracing.ForwardAnnotation | ||
import com.twitter.home_mixer.model.HomeFeatures._ | ||
import com.twitter.home_mixer.model.request.DeviceContext.RequestContext | ||
import com.twitter.home_mixer.model.request.HasDeviceContext | ||
import com.twitter.home_mixer.param.HomeMixerInjectionNames.DDGStatsAuthors | ||
import com.twitter.joinkey.context.RequestJoinKeyContext | ||
import com.twitter.product_mixer.component_library.model.cursor.UrtOrderedCursor | ||
import com.twitter.product_mixer.core.feature.Feature | ||
|
@@ -24,22 +22,16 @@ import com.twitter.snowflake.id.SnowflakeId | |
import com.twitter.stitch.Stitch | ||
import java.util.UUID | ||
import javax.inject.Inject | ||
import javax.inject.Named | ||
import javax.inject.Singleton | ||
|
||
@Singleton | ||
class RequestQueryFeatureHydrator[ | ||
Query <: PipelineQuery with HasPipelineCursor[UrtOrderedCursor] with HasDeviceContext] @Inject() ( | ||
@Named(DDGStatsAuthors) ddgStatsAuthors: YamlMap) | ||
extends QueryFeatureHydrator[Query] { | ||
) extends QueryFeatureHydrator[Query] { | ||
This comment has been minimized.
Sorry, something went wrong. |
||
|
||
override val features: Set[Feature[_, _]] = Set( | ||
AccountAgeFeature, | ||
ClientIdFeature, | ||
DDGStatsDemocratsFeature, | ||
DDGStatsRepublicansFeature, | ||
DDGStatsElonFeature, | ||
This comment has been minimized.
Sorry, something went wrong. |
||
DDGStatsVitsFeature, | ||
This comment has been minimized.
Sorry, something went wrong. |
||
DeviceLanguageFeature, | ||
GetInitialFeature, | ||
GetMiddleFeature, | ||
|
@@ -59,10 +51,6 @@ class RequestQueryFeatureHydrator[ | |
override val identifier: FeatureHydratorIdentifier = FeatureHydratorIdentifier("Request") | ||
|
||
private val DarkRequestAnnotation = "clnt/has_dark_request" | ||
private val Democrats = "democrats" | ||
private val Republicans = "republicans" | ||
private val Elon = "elon" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
MaG21
|
||
private val Vits = "vits" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. |
||
|
||
// Convert Language code to ISO 639-3 format | ||
private def getLanguageISOFormatByCode(languageCode: String): String = | ||
|
@@ -83,16 +71,6 @@ class RequestQueryFeatureHydrator[ | |
val featureMap = FeatureMapBuilder() | ||
.add(AccountAgeFeature, query.getOptionalUserId.flatMap(SnowflakeId.timeFromIdOpt)) | ||
.add(ClientIdFeature, query.clientContext.appId) | ||
/** | ||
* These author ID lists are used purely for metrics collection. We track how often we are | ||
* serving Tweets from these authors and how often their tweets are being impressed by users. | ||
* This helps us validate in our A/B experimentation platform that we do not ship changes | ||
* that negatively impacts one group over others. | ||
*/ | ||
This comment has been minimized.
Sorry, something went wrong.
MrCheeze
|
||
.add(DDGStatsDemocratsFeature, ddgStatsAuthors.longSeq(Democrats).toSet) | ||
.add(DDGStatsRepublicansFeature, ddgStatsAuthors.longSeq(Republicans).toSet) | ||
.add(DDGStatsVitsFeature, ddgStatsAuthors.longSeq(Vits).toSet) | ||
.add(DDGStatsElonFeature, ddgStatsAuthors.longValue(Elon)) | ||
This comment has been minimized.
Sorry, something went wrong.
zachnorman02
|
||
.add(DeviceLanguageFeature, query.getLanguageCode.map(getLanguageISOFormatByCode)) | ||
.add( | ||
GetInitialFeature, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,5 @@ | ||
package com.twitter.home_mixer.module | ||
|
||
import com.google.inject.Provides | ||
import com.twitter.config.yaml.YamlMap | ||
import com.twitter.home_mixer.param.HomeMixerInjectionNames.DDGStatsAuthors | ||
import com.twitter.inject.TwitterModule | ||
import javax.inject.Named | ||
import javax.inject.Singleton | ||
|
||
object HomeMixerResourcesModule extends TwitterModule { | ||
|
||
private val AuthorsFile = "/config/authors.yml" | ||
This comment has been minimized.
Sorry, something went wrong. |
||
|
||
@Provides | ||
@Singleton | ||
@Named(DDGStatsAuthors) | ||
def providesDDGStatsAuthors(): YamlMap = YamlMap.load(AuthorsFile) | ||
} | ||
object HomeMixerResourcesModule extends TwitterModule {} | ||
This comment has been minimized.
Sorry, something went wrong.
unixzii
|
177 comments
on commit ec83d01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bruh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TTours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiến đẹp trai đã ghé thăm!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we’re learning that these comments present a O = n^2 problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO YOU PEOPLE REALIZE HOW LONG DOES IT TAKE TO LOAD THIS PAGE??
MORE!!!!!!!!!!!!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the hell is happening here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@revelsix from a quick glance it seems that these are only used for analytics purposes, not actually affecting the algo
/** * These author ID lists are used purely for metrics collection. We track how often we are * serving Tweets from these authors and how often their tweets are being impressed by users. * This helps us validate in our A/B experimentation platform that we do not ship changes * that negatively impacts one group over others. */Can you read, sir? This allows them to validate that any/all changes have the desired effect. Boosting Elon. They can claim it’s so they don’t negatively impact one group over others all they want, but their actions do not have to actually reflect this.
Are you sure it was boosting Elon? Maybe it did something else. It's not clear from source code how Elon Musk was special.
Assuming this isn't sarcasm, the comment explains that the intent behind collecting those analytics is to ensure a change doesn't advantage one group over another. Elon hilariously having his own group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy shit please get me out of the quote chain I've unsubscribed from email notifications 5 times now and they keep coming back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're trapped in here with us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy shit please get me out of the quote chain I've unsubscribed from email notifications 5 times now and they keep coming back
You cannot escape Elon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me on my way to commit twittercide:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was here. History being made as the richest man tries to get his engineers to make him more popular.
Just run the emerald mine, dawg. Heard those are really hip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All you faggots go back to reddit and/or twitter. You will never learn to program and you will never be funny.
elon won't sleep with you, give it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All you faggots go back to reddit and/or twitter. You will never learn to program and you will never be funny.
keep crying about it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ynissar
💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Elon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi twitter dudes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commenting because i was here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone pulled a fork? cuz AFAICT once their AGPLv3'd code is forked, they'll have to FLOSS their entire API!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys just so you know force pushing a new initial commit doesn’t get rid of the old ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting because why not? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone pulled a fork? cuz AFAICT once their AGPLv3'd code is forked, they'll have to FLOSS their entire API!
That's not how this works. They still hold their original copyright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving my mark here in history!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adithya was here on 02/04/2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, I was here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, history!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just commenting on this thread because of FOMO ahahha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wtf is this thread 💀💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire commit takes 10 seconds to load in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to history folks.
Smile to the camera, because we caught it in 4K📸