Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

Commit

Permalink
Do not use '_' prefix for private methods.
Browse files Browse the repository at this point in the history
  • Loading branch information
psychs committed May 8, 2012
1 parent b80d7d4 commit 65402dc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lib/TwitterText.m
Expand Up @@ -284,7 +284,7 @@
static NSRegularExpression *endMentionRegexp;

@interface TwitterText ()
+ (NSArray*)_extractHashtags:(NSString*)text withURLEntities:(NSArray*)urlEntities;
+ (NSArray*)extractHashtags:(NSString*)text withURLEntities:(NSArray*)urlEntities;
@end

@implementation TwitterText
Expand All @@ -298,7 +298,7 @@ + (NSArray*)extractEntities:(NSString*)text
NSMutableArray *results = [NSMutableArray array];

NSArray *urls = [self extractURLs:text];
NSArray *hashtags = [self _extractHashtags:text withURLEntities:urls];
NSArray *hashtags = [self extractHashtags:text withURLEntities:urls];
[results addObjectsFromArray:urls];
[results addObjectsFromArray:hashtags];

Expand Down Expand Up @@ -441,10 +441,10 @@ + (NSArray*)extractHashtags:(NSString*)text checkingURLOverlap:(BOOL)checkingURL
if (checkingURLOverlap) {
urls = [self extractURLs:text];
}
return [self _extractHashtags:text withURLEntities:urls];
return [self extractHashtags:text withURLEntities:urls];
}

+ (NSArray*)_extractHashtags:(NSString*)text withURLEntities:(NSArray*)urlEntities
+ (NSArray*)extractHashtags:(NSString*)text withURLEntities:(NSArray*)urlEntities
{
if (!text.length) {
return [NSArray array];
Expand Down

2 comments on commit 65402dc

@caniszczyk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically breaks API IMHO so we should bump the version to 2.0.0 and retag :)

http://semver.org/

@psychs
Copy link
Contributor Author

@psychs psychs commented on 65402dc May 8, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.