Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabled attribute on tt-hint #839

Closed
theoephraim opened this issue May 2, 2014 · 2 comments
Closed

Remove disabled attribute on tt-hint #839

theoephraim opened this issue May 2, 2014 · 2 comments

Comments

@theoephraim
Copy link

Making tt-hint disabled makes ie8 and ie9 display the hint as grey with a white text shadow and the styles cannot be overridden. It's not a huge deal on a white input, but if you are making the input a darker color, it looks terrible.

Removing the disabled attribute and instead setting taborder="-1" seems to work ok and allows it to be styled properly in old IE.

Are there other reasons that I am overlooking for making the hint disabled?

@jharding
Copy link
Contributor

jharding commented Jul 9, 2014

The reason why the hint is disabled is to prevent end-users from changing the value and so that it's not sent to the server on a form submit. Since the hint input control has no name though, it won't be considered a successful control so that should take care of the not sending to the server part. Marking the control as readonly and setting taborder to -1 should take care of the other concerns.

I'll go ahead and make these changes and then verify everything works as expected across supported browsers. Thanks for reporting this issue, it's something I probably would have never stumbled upon on my own.

@jharding
Copy link
Contributor

jharding commented Jul 9, 2014

Fixed for v0.10.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants