fix: an overflow bug for div2_round #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a potential overflow bug for div2_round function. When parameter a of function div2_round has the maximum value, the result is 0 which is incorrect.
|
|
canbal
reviewed
Dec 22, 2017
imagecore/utils/mathutils.h
Outdated
| @@ -111,5 +112,8 @@ inline void swap(unsigned int& a, unsigned int& b) | |||
|
|
|||
| inline unsigned int div2_round(unsigned int a) | |||
| { | |||
| return (a + 1) / 2; | |||
| if (a == UINT_MAX) | |||
There was a problem hiding this comment.
Please use the following format
if (condition) {
// do first thing
} else {
// do second thing
}
|
@lukealonso this looks correct to me but please chime in as the primary owner for this piece of code. |
As required by the coding style, parentheses are added to the if statement in the previous commit.
|
@canbal @lukealonso done. |
Small style changes. Looks good, going to merge.
canbal
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential overflow bug for div2_round function.
When parameter a of function div2_round (in vireo/imagecore/utils/mathutils.h) has the maximum value, the result is 0 which is incorrect.