-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not compile on OSX (fix provided) #8
Comments
Thanks for the report, that's definitely something that should get fixed. @canbal This should just be using true/false, I probably had some Objective-C YES/NO brain damage the day I wrote this. |
@lukealonso: libjpeg is defining TRUE/FALSE as an @clauswitt: Can you provide info about your system and attach the full compilation log? |
System: macOS High Sierra 10.13.2 (was Sierra, latest, when I first tried). gcc version:
Output from configure:
Output from make:
Output from brew list:
|
Hi, I can still see this issue while compiling on mac. As mentioned above: Definition of TRUE and FALSE in /usr/local/include/lcms2.h
and looks like it is not able to access boolean definition from /usr/local/include/jmorecfg.h
The explicit typecasting mentioned above works but I made the following changes in ../imagecore/formats/internal/jpeg.h
and was able to compile. @canbal Let me know what you think. System config:
|
I am not sure if this warrants a PR - or if it was just my system that had some weird issue.
I had compile errors because of lcms.h (on my system) defining TRUE and FALSE as 1 and 0, and the compiler then sees integers assigned to booleans. (Hope that makes sense).
Output from make
The following diff fixes that problem:
The text was updated successfully, but these errors were encountered: