Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent types for StreamOptions vs. UserIdCollection #3

Closed
finsterdexter opened this issue Feb 16, 2012 · 2 comments
Closed

Inconsistent types for StreamOptions vs. UserIdCollection #3

finsterdexter opened this issue Feb 16, 2012 · 2 comments

Comments

@finsterdexter
Copy link

Apparently, UserIdCollection is storing user IDs as decimals? Any reason not to use int or long?

Also, the StreamOptions Follow property is a List<string>.

See the problem here? So, in my implementation, I have to convert the UserIdCollection from a collection of decimal to a List<string>. Seems like these should be normalized to a single type. Either return a List<string> from TwitterFriendship.FriendIds, or change StreamOptions Follow to UserIdCollection. (Although, what should probably happen is have them both normalized to List<int>, or List<long> if we think twitter will get over 2 billion users.)

@DigitallyBorn
Copy link
Member

Twitter is one of the fastest growing services on the internet. It may seems silly to use such a large datatype for an identity field, but I opted to allow for a very long life before I am forced to introduce a breaking change to the library. Use of the decimal datatype was also to keep identities consistant, since the status id requires a very large datatype. (It rolled past Int32 in June 2009.)

You're right that the follow property should be a numeric datatype.

@finsterdexter
Copy link
Author

That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants