Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcodes field is ignored #17

Open
suzukieng opened this issue Jan 16, 2024 · 0 comments
Open

Barcodes field is ignored #17

suzukieng opened this issue Jan 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@suzukieng
Copy link

Issue summary

The non-legacy barcodes field is ignored, while the barcode field works.

Expected behaviour

The barcodes field should result in JSON output corresponding to:
https://developer.apple.com/documentation/walletpasses/pass/barcodes

Actual behaviour

When using the barcodes field and setting it to a list of Barcode objects, its content are ignored.

In the code, there are comments regarding barcode being a legacy field and to use barcodes instead, but apparently it is unhandled, see:

# barcodes have 2 fields, 'barcode' is legacy so limit it to the legacy formats, 'barcodes' supports all

Steps to reproduce the problem

  1. Create a pass and set the barcodes field to a list of Barcode
  2. Build/sign the pass
  3. Observe that in the json no barcode output is generated

Checklist

  • [ x ] I have searched the issues of this repo and believe that this is not a duplicate.
@suzukieng suzukieng added the bug Something isn't working label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant