Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for graph building #2

Open
blevz opened this issue Mar 29, 2021 · 2 comments
Open

Add tests for graph building #2

blevz opened this issue Mar 29, 2021 · 2 comments

Comments

@blevz
Copy link
Collaborator

blevz commented Mar 29, 2021

Verify that we produce reasonable graphs for a set of envoy bootstrap configurations exercising various features
@blevz blevz changed the title Add Tests Add tests for graph building Mar 29, 2021
@esnible
Copy link
Contributor

esnible commented Mar 30, 2021

Can I send you some Istio Envoy dumps?

I added the necessary code to get envoy-viz to read my files, but the graph generation failed with

panic: runtime error: invalid memory address or nil pointer dereference

at graph/build.go:39 because my graph has no static resources.

@blevz
Copy link
Collaborator Author

blevz commented Mar 30, 2021 •
edited

Yes pls! Feel free to add them to testdata in a PR

Alternatively email them to ben.levy@twosigma.com and I'll get them in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blevz @esnible