http.delete queryParams overload #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsiq-karold
reviewed
Nov 25, 2019
| @@ -39,6 +40,7 @@ | |||
| public static final String PATH_EXPECTED_RETURN = "/full-echo"; | |||
|
|
|||
| public static final HttpQueryParams query = http.query("a", "1", "b", "text"); | |||
| public static final Map<String, ?> queryAsMap = WebTauCore.aMapOf("a", "1", "b", "text"); | |||
There was a problem hiding this comment.
I suspect there are existing tests that could make use of this, specifically tests for query param overrides for other http methods.
There was a problem hiding this comment.
Not sure I follow, could you please clarify?
There was a problem hiding this comment.
I'm saying things like https://github.com/twosigma/webtau/blob/master/webtau-http/src/test/java/com/twosigma/webtau/http/HttpJavaTest.java#L236 could use the queryAsMap you've defined here instead of redefining their own.
There was a problem hiding this comment.
OK, as discussed, these are completely unrelated classes (I assumed one was a base class of the other) so approving it as is.
tsiq-karold
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #336