Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.delete queryParams overload #458

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@MykolaGolubyev
Copy link
Collaborator

MykolaGolubyev commented Nov 24, 2019

closes #336

@@ -39,6 +40,7 @@
public static final String PATH_EXPECTED_RETURN = "/full-echo";

public static final HttpQueryParams query = http.query("a", "1", "b", "text");
public static final Map<String, ?> queryAsMap = WebTauCore.aMapOf("a", "1", "b", "text");

This comment has been minimized.

Copy link
@tsiq-karold

tsiq-karold Nov 25, 2019

Collaborator

I suspect there are existing tests that could make use of this, specifically tests for query param overrides for other http methods.

This comment has been minimized.

Copy link
@MykolaGolubyev

MykolaGolubyev Nov 25, 2019

Author Collaborator

Not sure I follow, could you please clarify?

This comment has been minimized.

Copy link
@tsiq-karold

tsiq-karold Nov 25, 2019

Collaborator

I'm saying things like https://github.com/twosigma/webtau/blob/master/webtau-http/src/test/java/com/twosigma/webtau/http/HttpJavaTest.java#L236 could use the queryAsMap you've defined here instead of redefining their own.

This comment has been minimized.

Copy link
@tsiq-karold

tsiq-karold Nov 25, 2019

Collaborator

OK, as discussed, these are completely unrelated classes (I assumed one was a base class of the other) so approving it as is.

@MykolaGolubyev MykolaGolubyev merged commit b1f86fc into master Nov 25, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@MykolaGolubyev MykolaGolubyev deleted the delete-query-params branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.