Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionBuilder Signature generation refactor #16

Merged
merged 2 commits into from Jan 21, 2022
Merged

Conversation

stephanfeb
Copy link
Contributor

- Transaction building suffered from a rather pernicious problem
  wherein it becomes hard/complicated to calculate fees.
  This stems from the fact that when you try to large number of
  utxos, the consequent large number of inputs in the spending tx
  leads to guesswork about the appropriate fee calculation.

  This update refactors the process of Transaction Signing so that
  the builder can directly generate the signed inputs and therefore
  perform the work of fee calculation internally.

  Please see the transaction/TransactionBuilderTest.java for an example use.

- Transaction building suffered from a rather pernicious problem
  wherein it becomes hard/complicated to calculate fees.
  This stems from the fact that when you try to large number of
  utxos, the consequent large number of inputs in the spending tx
  leads to guesswork about the appropriate fee calculation.

  This update refactors the process of Transaction Signing so that
  the builder can directly generate the signed inputs and therefore
  perform the work of fee calculation internally.

  Please see the transaction/TransactionBuilderTest.java for an example use.
@stephanfeb stephanfeb merged commit be70d9b into main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant