Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicise SitrepCore #27

Closed
Sherlouk opened this issue Feb 7, 2021 · 2 comments · Fixed by #28
Closed

Publicise SitrepCore #27

Sherlouk opened this issue Feb 7, 2021 · 2 comments · Fixed by #28

Comments

@Sherlouk
Copy link
Contributor

Sherlouk commented Feb 7, 2021

Hey @twostraws 👋

An awesome little tool that you've created here! I wonder if you'd be interesting in enabling SitrepCore as a product?

It would allow other people's tools to build on top of the great stuff you've built as part of their own projects. Of course, you have the JSON output which could be used with ShellOut and some Codable stuff but this a lot more to manage (and introduces more routes for problems) versus using the library directly.

In theory it would just be a case of adding the product to the Package.swift and making a couple extra things public!
@twostraws
Copy link
Owner

PRs most welcome!

@Sherlouk
Copy link
Contributor Author

Sherlouk commented Feb 7, 2021

Awesomeeeee 🙌🏼

I'll get on that 🤓

@Sherlouk Sherlouk mentioned this issue Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SitrepCore to SPM Products array Sherlouk/Sitrep-1
2 participants
@twostraws @Sherlouk