FIX: Image.renderText() in Xcode 12 beta 5 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be sure, this is also compatible with earlier versions of Swift, right? |
|
@twostraws I’m going to test it in Docker Action Items for this PR:
|
|
@twostraws Updated. I have confirmed this works in earlier versions of Swift |
|
Perfect - thank you very much! |
zntfdr
reviewed
Aug 23, 2021
| // `gdImageStringFT` returns the text bounding box, specified as four | ||
| // points in the following order: | ||
| // lower left, lower right, upper right, and upper left corner. | ||
| // upper left, upper right, lower right, and lower left corner. |
There was a problem hiding this comment.
Thank you for the update!
This edit is not correct:
renderTextreturnsupper left, upper right, lower right, and lower left corner.gdImageStringFTreturnslower left, lower right, upper right, and upper left corner.
The comment is about gdImageStringFT.
There was a problem hiding this comment.
@zntfdr @twostraws My apologies. I have a new patch ( #33 ) in to address the mistake.
There was a problem hiding this comment.
@mcritz Thank you for the quick patch ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Image.renderText()is great work.But the
renderTextmethod should pass pointers instead of values to gdImageStringFT. In fact, this causes compiler Errors in Xcode 12 Beta 5 (Swift 5.5).This PR fixes these errors.
Additional info:
(swiftlang-1300.0.20.104 clang-1300.0.21.1)