Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization #141

Closed
BasThomas opened this issue May 28, 2019 · 4 comments
Closed

Localization #141

BasThomas opened this issue May 28, 2019 · 4 comments

Comments

@BasThomas
Copy link
Contributor

I saw some user-facing strings that are not wrapped in an NSLocalizedString and I was wondering about the plans of localizing the app?

It might be a good idea to prepare for that, and it could be a nice task to get an overview of the code base. :)

(I might want to pick this one up myself 😄)
@twostraws
Copy link
Owner

Yes, I'm afraid the app isn't set up for localization right now – it might be a rather tricky prospect given the very large amount of data it contains. That being said, if you'd like to localize strings in the Swift code, go for it!

@BasThomas
Copy link
Contributor Author

BasThomas commented May 30, 2019 •
edited

Started working on it, and it is coming along quite nicely :)

@twostraws
Copy link
Owner

Can I assume, given your job situation @BasThomas, that this can be closed? 😅

@BasThomas
Copy link
Contributor Author

Someone else could pick it up! But feel free to close; I'm not currently working on it.

@BasThomas BasThomas mentioned this issue Aug 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twostraws @BasThomas