Avoid infinite loop when template value is empty

twpayne · Jan 11, 2019 · 17a590c · 17a590c
1 parent afd6994
commit 17a590c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/chezmoi/autotemplate.go b/lib/chezmoi/autotemplate.go
@@ -49,6 +49,9 @@ func autoTemplate(contents []byte, data map[string]interface{}) ([]byte, error)
 	sort.Sort(sort.Reverse(byValueLength(variables)))
 	contentsStr := string(contents)
 	for _, variable := range variables {
+		if variable.value == "" {
+			continue
+		}
 		index := strings.Index(contentsStr, variable.value)
 		for index != -1 && index != len(contentsStr) {
 			if !inWord(contentsStr, index) && !inWord(contentsStr, index+len(variable.value)) {

diff --git a/lib/chezmoi/autotemplate_test.go b/lib/chezmoi/autotemplate_test.go
@@ -110,6 +110,14 @@ func TestAutoTemplate(t *testing.T) {
 			},
 			wantStr: "{{ .alpha }} aa a aa {{ .alpha }} aa a aa {{ .alpha }}",
 		},
+		{
+			name:        "skip_empty",
+			contentsStr: "a",
+			data: map[string]interface{}{
+				"empty": "",
+			},
+			wantStr: "a",
+		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			got, gotErr := autoTemplate([]byte(tc.contentsStr), tc.data)