Don't quote shell args just because of equals signs

twpayne · Dec 13, 2019 · 91e562a · 91e562a
1 parent 871fb53
commit 91e562a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/internal/chezmoi/maybeshellquote.go b/internal/chezmoi/maybeshellquote.go
@@ -5,7 +5,7 @@ import (
 	"strings"
 )
 
-var needShellQuoteRegexp = regexp.MustCompile(`[^+\-./0-9A-Z_a-z]`)
+var needShellQuoteRegexp = regexp.MustCompile(`[^+\-./0-9=A-Z_a-z]`)
 
 const (
 	backslash   = '\\'

diff --git a/internal/chezmoi/maybeshellquote_test.go b/internal/chezmoi/maybeshellquote_test.go
@@ -8,16 +8,18 @@ import (
 
 func TestMaybeShellQuote(t *testing.T) {
 	for s, expected := range map[string]string{
-		``:    `''`,
-		`'`:   `\'`,
-		`''`:  `\'\'`,
-		`'a'`: `\''a'\'`,
-		`\`:   `'\\'`,
-		`\a`:  `'\\a'`,
-		`$a`:  `'$a'`,
-		`a`:   `a`,
-		`a/b`: `a/b`,
-		`a b`: `'a b'`,
+		``:            `''`,
+		`'`:           `\'`,
+		`''`:          `\'\'`,
+		`'a'`:         `\''a'\'`,
+		`\`:           `'\\'`,
+		`\a`:          `'\\a'`,
+		`$a`:          `'$a'`,
+		`a`:           `a`,
+		`a/b`:         `a/b`,
+		`a b`:         `'a b'`,
+		`--arg`:       `--arg`,
+		`--arg=value`: `--arg=value`,
 	} {
 		assert.Equal(t, expected, MaybeShellQuote(s), "quoting %q", s)
 	}