Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring CVEs #42

Closed
micheller opened this issue Jun 8, 2021 · 3 comments · Fixed by #47
Closed

Allow ignoring CVEs #42

micheller opened this issue Jun 8, 2021 · 3 comments · Fixed by #47
Labels
enhancement New feature or request

Comments

@micheller
Copy link

Motivation:
One might need a way to ignore a vulnerability

@twu
Copy link
Owner

twu commented Jun 8, 2021

Hej!

Thanks for giving skjold a shot! Sounds like a great idea! I already had a TODO for adding something like it at one point. So why not do it now :)

Here is my idea. Let me know what you think and whether you want to work on it or not :) Otherwise I will try to add it within the next weeks as I'm a little swamped with work ATM.

permanently

A file containing a list of identifiers of the findings to be ignored from the various sources should be easy enough to implement e.g. pyup.io-25625 (PyUp), GHSA-xwhf-g6j5-j5gc (Github) and CVE-2014-3225 (Gemnasium).

File .skjoldignore

pyup.io-39293  # user comment
pyup.io-25625  # some comment
GHSA-xwhf-g6j5-j5gc
...

The .skjoldignore file would then be picked up when running audit based on the ignore_file setting in the pyproject.toml or via passing -i <path-to-ignore>.

I'm not yet sure how output should be handled though and whether ignored findings should still be presented somehow. Maybe add a small note to cli and an ignored field to the json output, I guess?

temporarily

Adding an additional optional parameter I to pass a list of identifiers to be ignore e.g.

skjold audit -I pyup.io-25625,GHSA-xwhf-g6j5-j5gc ./requirements.txt

What do you think?

@twu twu added the enhancement New feature or request label Jun 12, 2021
@twu twu modified the milestone: v0.2.2 Jun 12, 2021
@twu twu linked a pull request Jun 19, 2021 that will close this issue
7 tasks
@twu
Copy link
Owner

twu commented Jun 19, 2021

I started implementing a slightly different approach after discovering how snyk and the .snyk file are handling this topic. I quite like the idea, see #47. I will try to release this as part of v0.3.0 later this month. Let me know what you think :)

@twu twu modified the milestones: v0.2.2, v0.3.0 Jun 19, 2021
@twu twu closed this as completed Jun 19, 2021
@twu
Copy link
Owner

twu commented Jun 19, 2021

Added it to develop and will do a release (v0.3.0) tomorrow (2020-06-20).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants