Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency in property name for custom reward types #300

Closed
CaveMobster opened this issue Oct 17, 2021 · 1 comment
Closed

Improve consistency in property name for custom reward types #300

CaveMobster opened this issue Oct 17, 2021 · 1 comment
Labels

Comments

@CaveMobster
Copy link
Collaborator

Feature Request

Currently HelixCreateCustomRewardData and HelixCustomReward have an inconsistency. The first has autoFulfill as a property name for should_redemptions_skip_request_queue, and the latter has autoApproved. I think it'd be nice to have them be the same name.

I'd like to update one of them and mark the old name as deprecated if that's okay. I think autoFulfill would semantically be the best name for it, but I'm more than happy to implement whichever is preferred.

@d-fischer
Copy link
Member

Fixed this for the next 5.1 prerelease, as deprecations don't usually go into patch versions (I'm trying to be more strict about this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants