Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image url getters for HelixChannelSearchResult, HelixGame and HelixVideo #322

Closed
CaveMobster opened this issue Jan 16, 2022 · 2 comments 路 Fixed by #324
Closed

Image url getters for HelixChannelSearchResult, HelixGame and HelixVideo #322

CaveMobster opened this issue Jan 16, 2022 · 2 comments 路 Fixed by #324
Labels

Comments

@CaveMobster
Copy link
Collaborator

Feature Request

Hi again 馃槃

I noticed that HelixChannelSearchResult, HelixGame and HelixVideo don't have an image url getter like HelixStream does for the thumbnail url, but I think they're really useful. Shall I implement them?

@d-fischer
Copy link
Member

The channel search returns non-templated profile picture URLs. For the rest, sure, you can go on and implement helper methods.

@CaveMobster
Copy link
Collaborator Author

My bad, the Twitch documentation says it returns variable dimensions, but it looks like the documentation is incorrect.

I'll get the others done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants