Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RefreshingAuthProvider events work like every other event based class #484

Closed
d-fischer opened this issue Apr 2, 2023 · 0 comments
Closed

Make RefreshingAuthProvider events work like every other event based class #484

d-fischer opened this issue Apr 2, 2023 · 0 comments
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Milestone
7.0

Comments

@d-fischer
Copy link
Member

The RefreshingAuthProvider currently handles events in a way that is different from pretty much everything else - it takes the callbacks as constructor parameter and does not allow dynamic changes to them.

Instead, it should just use the usual typed-event-emitter package.
@d-fischer d-fischer added improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change) labels Apr 2, 2023
@d-fischer d-fischer added this to the 7.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
1 participant
@d-fischer