Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ChatClient#connect and ChatClient#reconnect synchronous #486

Closed
d-fischer opened this issue Apr 2, 2023 · 0 comments
Closed

Make ChatClient#connect and ChatClient#reconnect synchronous #486

d-fischer opened this issue Apr 2, 2023 · 0 comments
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Milestone
7.0

Comments

@d-fischer
Copy link
Member

The methods ChatClient#connect and ChatClient#reconnect are marked as async even though they don't actually do anything asynchronous. Calling an async method without await has implications on execution order even if nothing async is actually executed in it, and therefore this should be fixed.
@d-fischer d-fischer added improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change) labels Apr 2, 2023
@d-fischer d-fischer added this to the 7.0 milestone Apr 2, 2023
@Arteandr Arteandr mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

#486 Make ChatClient#connect and ChatClient#reconnect synchronous Arteandr/twurple
1 participant
@d-fischer