Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parameters that only have implications for auth user resolution #487

Closed
d-fischer opened this issue Apr 2, 2023 · 0 comments
Closed

Remove parameters that only have implications for auth user resolution #487

d-fischer opened this issue Apr 2, 2023 · 0 comments
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Milestone
7.0

Comments

@d-fischer
Copy link
Member

d-fischer commented Apr 2, 2023 •
edited

Many methods (mostly moderation-related, but also follows now, and some others) have parameters that only determine authentication concerns. These parameters should be removed. If a method needs access to the resolved authentication user ID, it should be fetchable from the API client context.

Instead of passing the user (ID) as parameter, users shall be able to use the asUser or asIntent methods.
@d-fischer d-fischer added improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change) labels Apr 2, 2023
@d-fischer d-fischer added this to the 7.0 milestone Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
1 participant
@d-fischer