Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ebs-helper compatible across different runtimes using jose instead of jsonwebtoken #509

Closed
AdrianGonz97 opened this issue May 22, 2023 · 1 comment · Fixed by #510
Closed

Make ebs-helper compatible across different runtimes using jose instead of jsonwebtoken #509

AdrianGonz97 opened this issue May 22, 2023 · 1 comment · Fixed by #510
Labels
feature

Comments

@AdrianGonz97
Copy link
Contributor

Feature Request

jsonwebtoken unfortunately only works in Node so it'd be great to replace it with a jwt library that works across different runtimes like jose.

I already have a working implementation of this so that I would be able to use it with CF workers. I'd be more than happy to submit a PR for this change!
@d-fischer
Copy link
Member

d-fischer commented May 22, 2023 •
edited

Sure, feel free to PR this onto the main branch. I don't think this is a good fit for a patch version.

@AdrianGonz97 AdrianGonz97 mentioned this issue May 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced jsonwebtoken for jose in ebs-helper AdrianGonz97/twurple
2 participants
@d-fischer @AdrianGonz97