Squash 220226 #30
Merged
Squash 220226 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove symlinks rename include/exclude Add package check to install script Add requirements add required debian packages for installer add devel modules add systemd files make executable fix path of PIpfile add functions script to build working development environment add python packages rough documentation of changes remove add to do file typo Add missing module Add executable explicitly set the current directory update to do add install/uninstall/purge update to do install script completed update todo add help fix paths renamed for better clarity of purpose renamed update to use path of script more reilably pass command line args to paperpi update to point proper location make executable skip layouts update documentation update documentation update paths move venv check, update paths for plugins.md creation increase readability improve reliability clean up cruft fix error in regex fix Clear() functions Update install.sh Added a command (and relevant echoes) to attempt to install the missing python packages once before failing the script. Successfully tested on PiZeroW and Pi4, both running the latest 32-bit Bullseye Raspbian. Working through other issues with the 64-bit test device at the moment, but I will confirm this change on that one as well. Feel free to change the echo statement. I tried to keep the style close to what is there. Also fixed typo in output message of missing package
change method for processing args fix typo update readme with currently supported waveshare libs prompt with help if no option specified typo in case add check for pipenv add check for pip3 exit after failed pip3 check fix typo in name Update install.sh Adding function to check (and enable) SPI as part of the install. Update install.sh Added functions edit_config - prompt user to edit config file and open automatically if accepted start_service - auto start service if config was edited Edited functions finish_install - skip echo if config was edited during install Update remote_install.sh Changing for test...will revert later Update remote_install.sh Changing to public repo link Update install.sh Fix formatting Update remote_install.sh revert change for testing Update README.md Create README.md
fix missing data in dict I#16 offer resume option after abort
Add more robust directory discovery and abort message Add sudo to re-run message Remove auto install in deb pkg update readme with new install fix link Update README.md fix URL for issues Add Pi Zero and 64-bit as supported/tested and typo fix Update README.ipynb Fix typo in install command update md
cleanup .md docs and remove .ipynb Update install.sh Add trap for Ctrl-C to show resume path Update remote_install.sh Change branch for testing Update install.sh Fix variable name for abort() Update install.sh No '.' needed in resume path Update remote_install.sh Revert change made for testing. Add 'main' branch for eventual PR to main update plugin documentation update develiopment instructions abort after pipenv install fails fix init() for some displays ignore .vscode Add daemon start prompt Typo 'fi' Fix var spacing Add "$" to make command stand out Change service var in echo Update README with additional uninstall options Fix typo Fix typos in file paths (remove extra slash)
|
When this is merged into main, are you going to be ready to mark it as production ready? If not, we should add something in the Readme like you have in the current main branch readme. Otherwise, this looks great (and a lot cleaner)! |
Closed
2 tasks
|
That's a very good idea. I'll make a note in the readme and merge into main. |
|
I updated the README and finished the merge. I've created a new branch called "development" where we can muck around as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've squashed most of the commits and reworded a bit.
I'm kind of new to the idea of rebasing/squashing and could use another pair of eyes to see if anything looks out of whack.
This should resolve all of #28: Squashing commits and updating remote installer.