Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disparity between N2N and N2C for handling errors #40

Closed
scarmuega opened this issue Jan 8, 2022 · 1 comment
Closed

Disparity between N2N and N2C for handling errors #40

scarmuega opened this issue Jan 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@scarmuega
Copy link
Member

For example, when dealing with a block decoding issue, N2N will log the error (if enabled) and continue; while N2C will stop the state-machine and finally panic. Ideally, we stick to N2N way of handling errors.

Brought up in #37

cc @gitmachtl

@scarmuega scarmuega added the enhancement New feature or request label Jan 8, 2022
@scarmuega scarmuega self-assigned this Jan 8, 2022
@scarmuega scarmuega removed their assignment Jan 24, 2022
@scarmuega
Copy link
Member Author

this has been fixed by the pipeline overhaul in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant