Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for structured logging (JSON) #437

Open
4TT1L4 opened this issue Sep 21, 2022 · 1 comment · May be fixed by #438
Open

Support for structured logging (JSON) #437

4TT1L4 opened this issue Sep 21, 2022 · 1 comment · May be fixed by #438

Comments

@4TT1L4
Copy link
Contributor

4TT1L4 commented Sep 21, 2022

Problem:

  • At the moment only the standard env_logger based logging is supported. In some scenarios it would be beneficial, if Oura would support structured logging as well, in an easy to parse JSON format.

For a more detailed description about the structured logging format, please see the Google Cloud Documentation:

Suggestion:

  • Add a feature flag for the configuration of the logging method. Depending if the json_logs feature is set, Oura could be using json_env_logger2 or env_logger.
4TT1L4 added a commit to 4TT1L4/oura that referenced this issue Sep 21, 2022
@4TT1L4
Support for structured logging (JSON) txpipe#437
d7e25a7 
 - Added json_logs feature and made the used logging library dependend on the current feature flag setting.
@4TT1L4 4TT1L4 linked a pull request Sep 21, 2022 that will close this issue
Open
@4TT1L4
Copy link
Contributor Author

4TT1L4 commented Sep 21, 2022

I have created a PR with the proposed changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for structured logging (JSON) #437 4TT1L4/oura
1 participant
@4TT1L4