Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: potential for inaccurate data due to missing some blocks when using N2N #104

Closed
jmhrpr opened this issue Oct 15, 2022 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@jmhrpr
Copy link
Member

jmhrpr commented Oct 15, 2022

There is currently an issue which means some blocks (random) are not processed when using N2N, meaning the accuracy of data cannot be guaranteed. When attempting to roll forward to a new block header while following the tip, the server may sometimes respond to the BlockFetch message with a MsgNoBlocks instead of the requested block data, but Scrolls does not handle this case and behaves as if it processed the block. This means that any actions that would have occurred due to the missed blocks will not be reflected in the data in Scrolls.

@jmhrpr jmhrpr added the bug Something isn't working label Oct 15, 2022
@jmhrpr jmhrpr closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant