Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path]: Possible edge-case in custom regexes that need request query #323

Open
erbesharat opened this issue Mar 22, 2020 · 0 comments
Open

Comments

@erbesharat
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:
bug

What happened:
Currently, request path and query would get merged if the record's re= field contains the "?query" word. So if a custom regex doesn't need the request query but instead is looking for the "?query" inside the request path, there probably would be an error while finding the submatches.

What you expected to happen:
Find another way to pass the request query to the custom regex without checking it via the strings.Contains() method.

How to reproduce it (as minimally and precisely as possible):
"v=txtv0;type=path;re=/?query/testing"

@stp-ip stp-ip added this to the v0.5.0 milestone Mar 22, 2020
@stp-ip stp-ip modified the milestones: v0.5.0, v0.6.0 Apr 23, 2020
@stp-ip stp-ip modified the milestones: v0.5.1, v0.6.0 May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants