Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Share notes #16

Closed
julkue opened this issue Feb 9, 2016 · 8 comments
Closed

Feature request: Share notes #16

julkue opened this issue Feb 9, 2016 · 8 comments

Comments

@julkue
Copy link
Contributor

julkue commented Feb 9, 2016

A quite cool thing would be to share notes between people. In my opinion there are only two ways of doing this:

  • Implement a note export as JSON. Then the user could copy the code, save it in a file and send it to a friend. The friend could then import the file to see all the notes from his friend.
  • Setup an online service. The application would send all notes to it and it would save it in a database. Further it would generate a unique hash that is related to the notes. A user could then send this hash to a friend which could enter it in the application to retrieve the notes from his friend.

I personally prefer the first way as this is

  • less complex
  • brings no safety problems with it
  • makes no maintenance necessary
  • brings up no downtime issues
  • doesn't need an online connection
  • would be easy to implement as an automatically file export with the "Save as" dialog in hybrid apps

@txusko What do you think?

@txusko
Copy link
Owner

txusko commented Feb 9, 2016

It's a very good idea. Months ago I was thinking the best way to achieve the goal, but all solutions go through an online service and a user registration.
I think the json import/export will not be difficult to implement and fits a first approach to make the plugin more social.

Just out of curiosity, I'm currenly developing a new feature to share the note in the main social networks (twitter, fb & g+) 😄
https://github.com/txusko/PostItAll/tree/PostItAll-share-note

@julkue
Copy link
Contributor Author

julkue commented Feb 11, 2016

I agree. Do you plan to implement this?
It would not be so difficult like an online service. However, it will be a challenge though. Necessary to implement would be:

  • export the note itself as JSON
  • export the position or the attached element (unique selector creation would be necessary)
  • reimport the JSON to restore all things

@txusko
Copy link
Owner

txusko commented Feb 12, 2016

Sure, I don't know when but I will try to implement it.
If you have a clean picture of how and what to do, and you want to give me a hand, I will be eternally greatful 😄

@txusko
Copy link
Owner

txusko commented Mar 13, 2016

@julkue
Copy link
Contributor Author

julkue commented Mar 13, 2016

Hi Javi,
look great on first glance. I will review this tomorrow, as I don't have the time at the moment.
Cheers

@txusko
Copy link
Owner

txusko commented Mar 13, 2016

Don't worry, there's no rush. 😃

@julkue
Copy link
Contributor Author

julkue commented Mar 14, 2016

Thanks Javi. I appreciate your work and effort to build this feature.
For me the JSON looks pretty good and export/import worked in your example. I'm curious how this behaves when exporting/importing notes attached to elements or in a real application. I think I will have some further issues with this, but for the moment we can close this as successfully implemented.

@txusko
Copy link
Owner

txusko commented May 11, 2016

Merged : #32
Thanks again Julian

@txusko txusko closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants