Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attaching a note is buggy #29

Closed
julkue opened this issue Mar 14, 2016 · 3 comments
Closed

Attaching a note is buggy #29

julkue opened this issue Mar 14, 2016 · 3 comments

Comments

@julkue
Copy link
Contributor

julkue commented Mar 14, 2016

When attaching a note to an element, it looks bugy. A scrollbar will appear and the note will be overflown:

nothingappears

Code to reproduce:
noteTest.zip

Seems like a refactoring of this feature is necessary.

@julkue
Copy link
Contributor Author

julkue commented Jun 4, 2016

There's a project that realizes this and that will be a dependency for Bootstrap 4: http://tether.io/

Might be worth thinking about attaching nodes with this too.

@txusko
Copy link
Owner

txusko commented Jun 5, 2016

I didn't know that library, I will take a look ...
Thanks Julian

@txusko
Copy link
Owner

txusko commented Aug 30, 2016

Hey Julian, I was doing improvements in the attachedTo method. I think now the notes should be attached to the objects always in the visible browser area without scrollsbars.
655bc81

Anyway when I have time I will try to integrate the tether.io plugin

Best regards!
Javi Filella

@txusko txusko closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants