Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try conditional caching of miniconda #375

Merged
merged 1 commit into from Feb 6, 2020
Merged

Conversation

adelavega
Copy link
Member

@coveralls
Copy link

coveralls commented Feb 6, 2020

Coverage Status

Coverage increased (+0.06%) to 77.953% when pulling 1e573e2 on fix-miniconda-failures into 831ef84 on master.

@tyarkoni
Copy link
Collaborator

tyarkoni commented Feb 6, 2020

LGTM (I'm fine merging this change, whether or not it solves the actual problem)

@adelavega
Copy link
Member Author

Cool. I restarted the tests one final time, to test if it uses the cache properly. I tested without cache already and it worked. So if this passes I'm pretty sure it fixes the problem and I'll merge.

@adelavega
Copy link
Member Author

Looks like its working. Travis failure seems to be something else (timed out, but after env set up)

@adelavega adelavega merged commit 633c4bd into master Feb 6, 2020
@adelavega adelavega deleted the fix-miniconda-failures branch February 6, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants