Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python syntax and add python_requires for 3.5+ #393

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Apr 27, 2020

Fixes #391.

@tyarkoni
Copy link
Collaborator

Eep, I just opened #392...

Aside from minor differences between PRs, I'm not sure we want to drop 3.5 support yet given that ~20% of people are still on it. Do people have thoughts?

@hugovk
Copy link
Contributor Author

hugovk commented Apr 27, 2020

Ah! I thought Python 3.5 had already been dropped in #372, but that must just be the testing of 3.5.

Python 3.5 is still supported by core Python team until later this year, so it's fine to still keep it.

Although, NEP 29 is something to consider: https://numpy.org/neps/nep-0029-deprecation_policy.html

Let me know, and I'll drop that change!

@coveralls
Copy link

coveralls commented Apr 27, 2020

Coverage Status

Coverage decreased (-5.03%) to 71.324% when pulling 20a9db1 on hugovk:rm-2 into c272971 on tyarkoni:master.

@hugovk hugovk changed the title Remove redundant Python 2 code Upgrade Python syntax for 3.5+ and add python_requires Apr 27, 2020
@hugovk hugovk changed the title Upgrade Python syntax for 3.5+ and add python_requires Upgrade Python syntax and add python_requires for 3.5+ Apr 27, 2020
@tyarkoni tyarkoni merged commit 266518e into PsychoinformaticsLab:master Apr 27, 2020
@tyarkoni
Copy link
Collaborator

Thanks!

@hugovk hugovk deleted the rm-2 branch April 27, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop vestigial Python 2 features
3 participants