Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update librosa feature links #409

Merged
merged 4 commits into from Jul 15, 2020
Merged

update librosa feature links #409

merged 4 commits into from Jul 15, 2020

Conversation

PeerHerholz
Copy link
Contributor

@PeerHerholz PeerHerholz commented Jul 15, 2020 •
edited by adelavega

Update librosa links within audio.py to point to the specific feature site of the librosa docs instead of the generel feature site. Closes #363.

@adelavega
Copy link
Member

Hey looks great. Can you revert the changes to the requirements.txt file though? Or are they necessary? I think six should definitely be dropped, but otherwise, it's fine.

@PeerHerholz
Copy link
Contributor Author

Sorry for that, used the wrong head while experiencing a merge conflict. Should hopefully be ok now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 72.665% when pulling f46d13c on PeerHerholz:librosa_links into 9e4ad08 on tyarkoni:master.

@adelavega
Copy link
Member

Great, thanks!

@adelavega adelavega merged commit 3291840 into PsychoinformaticsLab:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Librosa: Should details on argument specification point to specific feature site?
3 participants
@PeerHerholz @adelavega @coveralls