Support guarding ordered transitions with a matching list of conditions #138
Comments
|
Hi @limdauto, I think this is a good idea. I did a review and added some remarks to the condition check. If you are still interested in this feature let me know. |
|
Hey @aleneum sorry I've been busy so I forgot about this. I will push an update soon. |
|
No worries, take your time :). We are not in a rush, are we? I just ping people if there has not been activity for two weeks to see if the issue still is valid. |
|
Hello @limdauto, if you okay with it, I will take your suggestions and adapt it a bit (see my review) so we can close this issue. What do you think? |
|
@aleneum hey sorry I forgot again. I don't think I need this feature anymore and it feels very niche to me so I will close the issue and the PR. |
aforren1
added a commit
to aforren1/transitions
that referenced
this issue
Feb 6, 2017
This adds the args present in add_transition, including: * conditions * unless * before * after * prepare * **kwargs This allows us to use conditional transitions and callbacks in ordered transitions. This continues the request in pytransitions#138.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I made a proof of concept for optionally guarding ordered transitions with a matching list of conditions. #137
I wonder if you are keen to merge it. If yes, I will add unittests and update README.
The text was updated successfully, but these errors were encountered: