Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing defaults for duration_buckets #4

Closed
christopherraa opened this issue Jan 3, 2018 · 2 comments
Closed

Missing defaults for duration_buckets #4

christopherraa opened this issue Jan 3, 2018 · 2 comments
Assignees

Comments

@christopherraa
Copy link
Collaborator

The documentation specifies that duration_buckets should have a default of (0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1.0, 2.5, 5.0, 7.5, 10). Such is not the case in the code.

Is the code or the doc at fault?

@tyldum
Copy link
Owner

tyldum commented Jan 3, 2018

Those are the defaults from Net::Prometheus in this case. I'm not sure it's best to document that instead or copypasta the defaults from Net::Prometheus. As it stands not it leaves room for errors, agreed.

@christopherraa
Copy link
Collaborator Author

Perhaps a note on that and where in Net::Prometheus those defaults can be found would be beneficial? Since their documentation does not hold those defaults the best thing might be to link directly to the line in code where it is defined.

@tyldum tyldum self-assigned this Jan 4, 2018
@tyldum tyldum closed this as completed in fcf3723 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants