Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[split-view] nested split views calculate incorrect initial sizes #383

Open
MikeMatusz opened this issue Sep 21, 2023 · 2 comments
Open
Labels

Comments

@MikeMatusz
Copy link
Contributor

Describe the bug:
When split views are nested, the initial sizes are incorrect.

To Reproduce:
Steps to reproduce the behavior:

  1. Open the StackBlitz reproduction
  2. Note that the "inner left" and "inner right" panels are supposed to each be 50%, but are clearly not the same size.
  3. Note that "top" should be 40% of the available height, but is more than that.
  4. Click "Adjust" to re-run private "apply size" logic and correct the sizes.

Expected behavior:
The initial sizes should be the same as the sizes after clicking "Adjust"

Screenshots:
See StackBlitz example for visuals

Please complete the following information:

  • Forge version: 2.17.0
  • I have searched existing issues before creating this report? Y
  • Browser: All
  • Platform: All
  • OS: All

Additional context:

@MikeMatusz MikeMatusz added the bug Something isn't working label Sep 21, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 21, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@MikeMatusz
Copy link
Contributor Author

I've also discovered that if the split-view is inside a view-switcher, switching tabs will cause panel widths to go to zero. I could potentially open a separate issue for that. Since I am specifying my widths as percentages, though, I think #388 could potentially address both of these problems for me, but unless we always want to convert pixels into percent, we may still need to address this for those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants