Comments issue

[tonib]

It seems there is some kind of problem with comments on 2.0.2 right now. The CSS:

#sidebar { }
/*********************************************************************************/
/* Footer                                                                        */
/*********************************************************************************/

#footer {}

/*********************************************************************************/
/* Copyright                                                                     */
/*********************************************************************************/

#copyright {}

W3C CSS validator says its OK.

This test is failing:

        [Test]
        public void TestComments()
        {
            string comments = "#sidebar { }\r\n" +
                "/*********************************************************************************/\r\n" +
                "/* Footer                                                                        */\r\n" +
                "/*********************************************************************************/\r\n" +
                "\r\n" +
                "#footer {}\r\n" +
                "\r\n" +
                "/*********************************************************************************/\r\n" +
                "/* Copyright                                                                     */\r\n" +
                "/*********************************************************************************/\r\n" +
                "\r\n" +
                "#copyright {}\r\n";

            var stylesheet = new Parser().Parse(comments);
            Assert.AreEqual(0, stylesheet.Errors.Count);
        }

The error is "Expected comment to close before end of file."

[TylerBrinks]

Thanks for posting that. I'll take a look, but feel free to post any ideas or pull requests in the meantime.

[tonib]

Ok, my ideas. I'll put them here because I have no idea about how github works...

I know this is a go-to-hell-dont-request-stupid-things petition, but what I will REALLY need is a version 2 compiled with .NET 3.5 (we write a plugin for other application that is compiled with that version).

I already did it myself, but the code needs changes... The most ugly is to implement the Tuple class (it does not exists in .NET 3.5), the other changes are trivial (change "var" declarations to "List<string>", etc). I warn you I have no tested the changes due to this reported issue.

Right now I'm using v1 of ExCSS, and I'm almost happy (its changing my "font-family: 'Source Sans Pro';" to "font-family: 'SourceSansPro';", but I can whip the design staff, so it's no problem )

[TylerBrinks]

Best place to start is by forking the project. You can create a fork and make any changes needed to back-port to older framework versions. I didn't have any plans to do so myself, but I'd be happy to take a pull request to make a 3.5 compatible version available.

[bcanzanella]

Hey Tyler,

I'm running into the same issue with multi-line comments with additional *s. Do you have any ideas on a fix? I can take a peek at it, but I didn't know if you had a chance to look.

[TylerBrinks]

This should be addressed with latest merge. Please submit a new issue if you find otherwise.