Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button and modal transition mismatch #1

Closed
terenc3 opened this issue May 3, 2024 · 1 comment · Fixed by #2
Closed

Close button and modal transition mismatch #1

terenc3 opened this issue May 3, 2024 · 1 comment · Fixed by #2

Comments

@terenc3
Copy link

terenc3 commented May 3, 2024

When closing the modal it disappears immediately but the close button has a 200ms transition. I would either add a transition to the card as well or restrict the transition to only affect the filter property (i guess that is the reason it was added).

P.S. I hope you saw the eclipse and can check that card 🙂

@tylercrumpton
Copy link
Owner

tylercrumpton commented May 7, 2024

Good catch! Fixed up the animations a little, and there was a bit of a graphical glitch with the different fading times, so that's been cleaned up as well, so it feels a bit cleaner now. Thanks!

(And we kinda got to see the eclipse! Super cloudy in Rochester, but it was still super super cool!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants