Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to set max zoom #58

Open
GoogleCodeExporter opened this issue Apr 3, 2015 · 0 comments
Open

Pull request to set max zoom #58

GoogleCodeExporter opened this issue Apr 3, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

Not sure how to do a pull request ala GitHub, so I'm filing as an issue. This 
is a feature I added for my own benefit.  I added a new contextual menu item to 
PlayActivity to go to the maximum zoom level.  

The maximum zoom was a magic number of 2.5F, but on a phone my eyes need a 
greater magnification.  I did some refactoring of the literal float into a 
roughly calculated value in PlayboardRenderer.getDeviceMaxScale().

There is another instance of 2.5F in ScrollingImageView.maxScale, but I'm not 
certain how this value interacts with the one in RENDERER, so I left it alone.

Tested on XOOM, Nexus 7 and Nexus 5.

https://code.google.com/r/ehcloninger-shortyz/source/detail?r=cbfe4dda94698b03a8
8d970df41a59bb2ea9c1d8

hg put R.Java in the commit, but it's clearly not needed.

Original issue reported on code.google.com by ehclonin...@gmail.com on 3 Mar 2014 at 3:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant